search

tbvdm / sigtop

Export messages from Signal Desktop
Other
281 stars 12 forks source link

Add support for Signal Beta in safe storage #62

Open jsutlovic opened 1 month ago

jsutlovic commented 1 month ago

Hi there,

sigtop currently hardcodes "Signal" as the app name for safe storage, but at least on MacOS, Signal and Signal Beta use a different safe storage:

Screenshot 2024-10-25 at 4 56 08 PM

I've fixed this in my branch here, I can create a PR if you'd like.

tbvdm commented 1 month ago

Hi. Thank you very much! Your changes look great! However, I think a better approach is to introduce a -B flag that should change the app name to "Signal Beta" and also adjust the Signal directory (unless already specified with -d). I don't know if you're willing to adjust your fix, but if you are, that would be great!

jsutlovic commented 1 month ago

I did initially consider that option but I wasn't sure if all platforms used the same pattern for Signal Beta. I should be able to update the branch to use a -B flag instead, though, I'll update once it's ready.

tbvdm commented 3 weeks ago

I did initially consider that option but I wasn't sure if all platforms used the same pattern for Signal Beta.

Ah, I see. Yes, it's the same pattern as far as I know.

I'll update once it's ready.

Great!

jsutlovic commented 3 weeks ago

Hi @tbvdm, I've updated the branch and was able to test/validate again, it seems to work as expected.

tbvdm commented 2 weeks ago

Looks good! Could you create a PR?