search

tchak / grape-middleware-lograge

MIT License
8 stars 19 forks source link

use alternative sql subscription method #2

Open mattyr opened 7 years ago

mattyr commented 7 years ago

This "fix" takes the approach mentioned in the comments at rails/rails#12069. It leverages an alternative but still public api, and just tracks the duration internally rather than using the subscription args.

buermann commented 7 years ago

I'm running into the same issue with a rails 4.2.8 project. +1 for the fix.

mattyr commented 7 years ago

@buermann does this pull request fix it for you?

buermann commented 6 years ago

It's only been a year! This always blew up in production whenever we tried to deploy it, with garbage collection going through the roof. Working from tchak's master I found memory leaks that were causing our problems, on top of the intermittent missing start times.

https://github.com/tchak/grape-middleware-lograge/pull/6