search

tchellomello / python-amcrest

A Python 2.7/3.x module for Amcrest and Dahua Cameras using the SDK HTTP API.
GNU General Public License v2.0
216 stars 76 forks source link

PTZ: PositionABS command added #128

Closed mehdilauters closed 3 years ago

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.006%) to 31.748% when pulling 0ab758c01900b2920b7697cd12d4b0544d67f3a4 on mehdilauters:positionABS into 551dfcaa5a83a3b6b1a10579500356378758a81f on tchellomello:master.

aknakn commented 4 years ago

Is the PositionABS code still valid as a command? I have purchased two cameras IP2M-841B and IP4M-1051B that both have firmware version from 2019 on the camera. The other commands such as Position, Right, or Up work correctly but the PositionABS command returns "Error Bad Request!"

Does anyone have PositionABS working correctly on devices with newer firmware?

NickWaterton commented 4 years ago

I also have an IP2M-841B with firmware version from 2019 on the camera, and get the same problem PositionABS command returns "Error Bad Request!".

So i think this command is no longer valid on the latest firmware.

dougsland commented 3 years ago

Hi @mehdilauters could you please fix the conflict for a fresh review?

dougsland commented 3 years ago

I also have an IP2M-841B with firmware version from 2019 on the camera, and get the same problem PositionABS command returns "Error Bad Request!".

So i think this command is no longer valid on the latest firmware.

Thanks for the comment @NickWaterton

flacjacket commented 3 years ago

@mehdilauters it looks like there are still merge conflicts with master, you'll need to rebase or merge the current master to be able to merge this PR.