search

tchellomello / python-amcrest

A Python 2.7/3.x module for Amcrest and Dahua Cameras using the SDK HTTP API.
GNU General Public License v2.0
216 stars 76 forks source link

Media and Log functions #135

Closed maximvelichko closed 4 years ago

maximvelichko commented 4 years ago

1) @jessbo's changes to retrieve media files (https://github.com/jessbo/python-amcrest) 2) Log retrieval functionality

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.06%) to 31.678% when pulling ab45ace043991a57944a7009103686bf9b788f5c on maximvelichko:media-log into 3b0457c4743edb1973bee5bd6174e055829b8757 on tchellomello:master.

maximvelichko commented 4 years ago

I believe the code coverage is based on test in tests/test_utils.py They are for amcrest.utils only, so I see no way to increase the coverage without introducing e.g. mocks for src/amcrest/http.py. (And any added functionality would decrease the coverage).

If I miss something, and there is a way to increase coverage for what I am adding - please let me know, I'd be glad to add it