Ability to set default timeout for all commands

tchellomello / python-amcrest

A Python 2.7/3.x module for Amcrest and Dahua Cameras using the SDK HTTP API.

GNU General Public License v2.0

216 stars 76 forks source link

Ability to set default timeout for all commands #23

Closed colinodell closed 7 years ago

colinodell commented 7 years ago

Right now, it looks like scan_devices() might be the only function where you can pass in a custom timeout. In other cases, such as snapshot(), there's no way to override the default timeout of 3 seconds.

dougsland commented 7 years ago

My first attempt tonight: https://github.com/tchellomello/python-amcrest/pull/26

tchellomello commented 7 years ago

Implemented on #26.

dougsland commented 7 years ago

@colinodell I believe this new PR (bellow) should cover this request, please let us know in case it's still missing something: https://github.com/tchellomello/python-amcrest/pull/28

Also, fell free to comment before we merge patches. Thanks!