search

tcunis / bisosprob

Toolbox for bilinear sum-of-squares problems.
4 stars 3 forks source link

Userstep #20

Closed renatoloureiro closed 2 years ago

renatoloureiro commented 2 years ago

I believe the new step is working fine and well written, the only aspect that I would like to discuss is if it's a good idea that the user defined function receives the variable prob every time. Also this new step can only have one output, i.e. one variable as output.

renatoloureiro commented 2 years ago

With the latest commit https://github.com/tcunis/bisosprob/pull/20/commits/50a138ed1119e6c2b2d9d5c9c794dfd09986994d , all the previous requested changes have been handled

renatoloureiro commented 2 years ago

Looks good to me. I have just tidied up the demos. Why do we allow the transfer step to only change a single variable?

Right now with the current step, it only allows for a single output, i.e. change in only one variable. I understand that we could extend this to multiple outputs instead of just one, but I decided that it would be better to just have one output. So that while using it, the output depends on all inputs, simple example: p, V <- b, c, a (multiple outputs) equivalent to p <- b V <-c, a

all outputs don't necessarily depend on all inputs in the multiple outputs case.