tdlight-team / tdlight-telegram-bot-api

The TDLight Telegram Bot API is an actively enhanced fork of the original Bot API, featuring experimental user support, proxies, unlimited files size, and more.
https://t.me/TDLight
Boost Software License 1.0
124 stars 27 forks source link

Fix camelCase of userLogin in the docs. #43

Closed luckydonald closed 3 years ago

spontanurlaub commented 3 years ago

@luckydonald No, only userlogin in lowercase works. The case is usually ignored, but this is a special method where this is not possible. Please have a look at the respective code.

luckydonald commented 3 years ago

In that case it should be changed in the code to be camelCase IMO. It really doesn't make sense to have a single endpoint work differently to all the others.

spontanurlaub commented 3 years ago

It's a bit of a mixture between an endpoint and the /bot or /user path part. I think having it lowercase is fine

luckydonald commented 3 years ago

@code1mountain If it would be /user/login I'd be all on board with you. Most users would expect it to be like the telegram docs do it, camelCase. The ability for lower case has not been documented, and are not widely known or used.

skrtdev commented 3 years ago

@luckydonald In the official docs of bot api is stated that all the methods names are case insensitive

luckydonald commented 3 years ago

@skrtdev Ah yes. Indeed. Missed that. Still, I'd rather keep it similar to the documentation's casing.

andrew-ld commented 3 years ago

@giuseppeM99 merge?

MarcoBuster commented 3 years ago

@andrew-ld the build failed (because GitHub), I just restarted it. Wait until it's completed.