search

tdryer / hangups

the first third-party instant messaging client for Google Hangouts
https://hangups.readthedocs.io/
MIT License
1.71k stars 189 forks source link

Fix order of email parameters to User constructor #512

Closed Terrance closed 3 years ago

Terrance commented 3 years ago

510 added canonical_email to User objects:

https://github.com/tdryer/hangups/blob/84f2dbcd795e7fe97ecb4766622620c0aa6e682c/hangups/user.py#L31-L32

...but the default assignments of that and emails are the wrong way around in some cases ([], None should be None, []):

https://github.com/tdryer/hangups/blob/84f2dbcd795e7fe97ecb4766622620c0aa6e682c/hangups/user.py#L124-L125

https://github.com/tdryer/hangups/blob/84f2dbcd795e7fe97ecb4766622620c0aa6e682c/hangups/user.py#L179

tdryer commented 3 years ago

Thanks!