team401 / 2024-Robot-Code

Competition code for our 2024 robot
Other
7 stars 0 forks source link

add missing paths for automation #191

Closed linglejack06 closed 7 months ago

linglejack06 commented 7 months ago

Summary: Add missing path planner paths to facilitate full automation of tele-op

linglejack06 commented 7 months ago

@jkleiber would it make sense to move the driveTo methods to a command file? I just feel like we could separate some to make drive class a little smaller? Or would that not work since it has to be in drive class

also could you let me know if I did the path right? i have never used the path planner GUI

jkleiber commented 7 months ago

@linglejack06 my preference for now is to keep these driveTo methods in the subsystem rather than creating specific commands. The reason being that I think it's better to keep everything centralized in relevant subsystems and then use InstantCommands to trigger these behaviors.

I can take a look at the path today at shop, I imagine it would be a short path that helps the robot approach the source - in the future it is helpful to post a screenshot of the path

linglejack06 commented 7 months ago

Okay that makes sense

That's the path I added so it should work as long as I got the rotation aspect correct