teambition / rrule-go

Go library for working with recurrence rules for calendar dates.

MIT License

310 stars 57 forks source link

Fix DTStart not changing internal rrules and exrules #22

Closed srikrsna closed 5 years ago

srikrsna commented 5 years ago

20

coveralls commented 5 years ago

Coverage increased (+0.001%) to 99.635% when pulling 1abf489281612e225896173088307c2bbf28b2b6 on srikrsna:rrset-dtstart-fix into c53b0d05b9ec81622ba8b598584a931146ad248f on teambition:master.

srikrsna commented 5 years ago

Is there a problem with this pr?

zensh commented 5 years ago

srikrsna commented 5 years ago

@zensh Thank you for that. I really don't see the suggestion. There's something wrong with Github. Anyhow may I ask why is it not necessary for exrule?

srikrsna commented 5 years ago

@zensh Not setting it for ex rule will again be inconsistent as it is being set when the set is parsed from a string here

zensh commented 5 years ago

@srikrsna You are right