teambition / rrule-go

Go library for working with recurrence rules for calendar dates.
MIT License
310 stars 57 forks source link

Honor TZID when evaluating UNTIL [Issue 37] #38

Closed Ferix9288 closed 4 years ago

Ferix9288 commented 4 years ago

Issue: https://github.com/teambition/rrule-go/issues/37

Easy fix where I call StrToROptionInLocation with defaultLoc instead of just StrToROption that defaults to UTC.

        case "RRULE", "EXRULE":
            rOpt, err := StrToROptionInLocation(rule, defaultLoc)
            if err != nil {
                return nil, fmt.Errorf("StrToROption failed: %v", err)
            }

Other notable changelog:

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 99.663% when pulling 3c634b3a36fd6fdbea07c53d4897bcb8d8562cd0 on Ferix9288:fix_issue_37 into c4b1bf2c7bbb37a14f9614eaf0b5d764fc173269 on teambition:master.

Ferix9288 commented 4 years ago

Never mind. Looks like this is intentional behavior based on the RFC spec.