search

teamcfadvance / CFSelenium

A native Selenium WebDriver binding for ColdFusion
Apache License 2.0
82 stars 32 forks source link

Develop #15

Closed Lampei closed 8 years ago

Lampei commented 10 years ago

I have updated the library to take advantage of the WebDriver portion of selenium (along with accounting for the Selenium-RC portion). The Read Me will still need to be updated, but I've added unit tests for the new features and fixed some issues with the previous unit tests. I've added some comments along the way to try to assist others with issues I ran into when using selenium v1 code. I've also added the latest selenium jar file and updated all references.

bobsilverberg commented 10 years ago

Thanks for doing this @Lampei! I am not in a position to test this, as I am no longer maintaining the code, and don't even have any CF environments on which to run it. Do you think you can find someone (another CFSelenium user) who can review the code and run the tests?

Lampei commented 10 years ago

No problem. Hopefully it'll be useful to others as well. I'll grab one of my coworkers to set it up on their local and make sure everything works for them. I've actually got some documentation (just word docs with embedded pics) for some of my coworkers to use for setup (and 'gotchas'), so if you like I can add those also (not sure best practice for how/where to add via git as this was my intro/attempt at using git "properly" via your git workflow series also :) ) I was also looking into travis-CI to try to automate this process and try to assist you in approving...but that will be next steps.

DannyCork commented 10 years ago

Lampei, thanks for the contrib however as CFselenium was not actively maintained and I merged newer commits first there now exist some conflicts. I'll close this for now, feel free to resubmit. Thanks.

DannyCork commented 10 years ago

reopened pending testing by TeamCF

Lampei commented 10 years ago

Haven't been able to do much with this lately. Hopefully you guys will be able to test and integrate my changes. I began work on the CI work, but didn't get around to finishing it up. I don't think those changes will impact the v2 updates. I've also got the Javascript calls working and added a pageFactory for page objects, but haven't been able to push them.

cfmitrah commented 9 years ago

Is this going to merged into master?

mattwebdev commented 9 years ago

this looks pretty awesome. im a huge fan of webdriver.

DannyCork commented 9 years ago

conflicts need to be resolved before merging, who want's to be a super hero ?

mattwebdev commented 9 years ago

I may take a crack at it this weekend.

jamiejackson commented 8 years ago

Resolved conflicts in https://github.com/teamcfadvance/CFSelenium/pull/25

@Lampei, could you have a look to see if this is in line with your original intent?

Lampei commented 8 years ago

Excellent! @jamiejackson glad someone got around to be able to merge it in. I'd started to get the CI portion going but ran out of time.