search

teamhephy / postgres

MIT License
2 stars 6 forks source link

feat(postgres): use docker's official postgres:11 image #4

Closed duanhongyi closed 5 years ago

duanhongyi commented 5 years ago

The original pg9.4 is too old and needs to maintain an independent boto; so I upgraded to the latest pg11, and all Python dependencies were in the official version. I have passed tests in swift and minio, and I am trying to build other environments.

Cryptophobia commented 5 years ago

@duanhongyi , looks like Travis CI is failing because Docker needs to build image before we run tests. We will need to submit a PR to fix this and rerun our tests: In travis.yml: script: make test should become: script: make docker-build && make test

Have you tried running the controller with this new database image?

duanhongyi commented 5 years ago

@duanhongyi , looks like Travis CI is failing because Docker needs to build image before we run tests. We will need to submit a PR to fix this and rerun our tests: In travis.yml: script: make test should become: script: make docker-build && make test

Have you tried running the controller with this new database image?

Yes, there is no problem with the controller. I'm still doing other tests. First, don't merge. I'll do a system test tomorrow.

duanhongyi commented 5 years ago

@Cryptophobia Hi Hi, the test has passed.

make docker-build && make test

duanhongyi commented 5 years ago

This PR has been running for two days in our pre-release environment, there are five physical machines in this environment, I think there should be no problem.

duanhongyi commented 5 years ago

add the latest Minio support, see this PR.

Cryptophobia commented 5 years ago

Merging now as it all looks resolved. Thank you @duanhongyi .

yebyen commented 5 years ago

This broke some stuff, the image no longer has ca-certificates package in it, at least. Also missing wget or curl for debugging purposes...

duanhongyi commented 5 years ago

This broke some stuff, the image no longer has ca-certificates package in it, at least. Also missing wget or curl for debugging purposes...

Is ca-certificates necessary?

kingdonb commented 5 years ago

It is in #3 – I haven't tested all of the previously supported cloud providers, but I was not able to connect to Digital Ocean Spaces with S3_ENDPOINT without ca-certificates, yes.

duanhongyi commented 5 years ago

@Cryptophobia @yebyen

Sorry, I didn't verify this in S3 environment. ca-certificates have been added to postgres: 11-alpine. #5

kingdonb commented 5 years ago

awesome! I will test that next, thank you very much