search

techknowlogick / xgo

Go CGO cross compiler
MIT License
478 stars 79 forks source link

Fix yet another bug with go-gettable modules #193

Closed zeripath closed 1 year ago

zeripath commented 1 year ago

There was another bug needing to be fixed in #187 - /source/go.mod does not exist in go-gettable modules therefore the NAME determination will fail.

Fix #187

Signed-off-by: Andrew Thornton art27@cantab.net

zeripath commented 1 year ago

I think this must have been missed because of the problem in the CI where it isn't testing with the rebuilt dockers

zeripath commented 1 year ago

We're still not using the recreated dockers in the bats tests... I'm trying to hack this in but it's totally opaque as to how to force bats to use rebuilt dockers.

zeripath commented 1 year ago

OK I give up on trying to get the CI to work properly for the moment. I've pushed this PR back to the simple fix. @techknowlogick you might need to just forcibly merge and I'll try to work out how we can have a CI that actually tests what the PRs are doing.

m90 commented 1 year ago

@zeripath my binaries build nicely again using this patch, thank you :tophat:

zeripath commented 1 year ago

well it's probably a combination of this one & #194.

zeripath commented 1 year ago

sorry that things were broken for so long.