search

technojam / technojam-frontend

This is the repository for TechnoJam's website frontend, for work please work on Development 1.0. Please do git pull before giving a pull request.
https://technojam--web.herokuapp.com/
MIT License
33 stars 97 forks source link

dark mode contrast issue fix in teams inner page #279

Closed itsvvishnu closed 4 years ago

itsvvishnu commented 4 years ago

Text color contrast issue in team's inner page when toggling to dark mode has been fixed in this pr

Ritwik880 commented 4 years ago

Hii @itsvvishnu can you please share some screen shots of the changes you have made.

itsvvishnu commented 4 years ago

Hii @itsvvishnu can you please share some screen shots of the changes you have made.

code or webpage?

Ritwik880 commented 4 years ago

webpage

itsvvishnu commented 4 years ago

webpage

Screenshot from 2020-10-18 22-49-20 Team member's name was not readable in darkmode before

Ritwik880 commented 4 years ago

@itsvvishnu Please have a look into #277 Pr.

itsvvishnu commented 4 years ago

@itsvvishnu Please have a look into #277 Pr.

The issue was not closed that's why i made a pr, and I did not change the class based component into a functional component, i kept everything the same