technologiestiftung / ki-portrait

images from the KI-Portrait exhibit @ CityLAB Sommerfest 2023
https://ki-portrait.citylab-berlin.org
MIT License
1 stars 0 forks source link

add script and extended json #7

Closed julizet closed 1 year ago

julizet commented 1 year ago

This PR adds the following two files to the Repo:

Each object in the json has been extended with the material and style properties, each extracted by the script from the prompt.

netlify[bot] commented 1 year ago

Deploy Preview for ki-portrait ready!

Name Link
Latest commit 83a0410f3a4863be732ed31552be35a0d08110ed
Latest deploy log https://app.netlify.com/sites/ki-portrait/deploys/64e4c7f62d9f7e0008105acf
Deploy Preview https://deploy-preview-7--ki-portrait.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ff6347 commented 1 year ago

Another request. Don't call the script main.cjs since main seems like some entrypoint script. Name it after what it does parse-matrials-and-styles-from-prompt.js or something a little shorter. Therefore in future times we only need to read the filename to know what it does and not read the whole source code.

ff6347 commented 1 year ago

Another. Maybe extend the README with 3 lines about the script

ff6347 commented 1 year ago

Another one. Please adopt conventional commits. Since we use it everywhere to do releases.