search

techouse / select-auto-complete

An auto-completing Laravel Nova search field
MIT License
31 stars 17 forks source link

Outdated required() method #9

Closed flexchar closed 5 years ago

flexchar commented 5 years ago

Declaration of Techouse\SelectAutoComplete\SelectAutoComplete::required() should be compatible with Laravel\Nova\Fields\Field::required($callback = true)

techouse/select-auto-complete/src/SelectAutoComplete.php:8

flexchar commented 5 years ago

After brief investigation I'd just say you don't really need extra required() method. Just remove the method and the feature (required - OPTIONAL - Make the field required. Default is false.) and it will be fine! :)

techouse commented 5 years ago

Thanks for the PR! ❤️

techouse commented 5 years ago

Hmm, however now Vue single select won't get the required field prop. I'll check how to circumvent this.

techouse commented 5 years ago

Aha, you forgot to remove the required param on line 36. Fixed :)

flexchar commented 5 years ago

Thanks for fast fix, and yes that was a quick online edit example!