search

tecosaur / org-pandoc-import

Mirror of https://git.tecosaur.net/tec/org-pandoc-import
GNU General Public License v3.0
245 stars 14 forks source link

Repo is unusable without git-lfs #1

Closed aaronjensen closed 4 years ago

aaronjensen commented 4 years ago

It looks like you used git-lfs to store screenshots/csv.png. If one does not have git-lfs installed, the repo cannot be checked out without erroring, which means it cannot be installed with straight.

tecosaur commented 4 years ago

Oh, that's a pain! I can host the images elsewhere, which is one half of the solution. Do you know if/how I can remove lfs?

tecosaur commented 4 years ago

Ah, found this: https://gist.github.com/everttrollip/198ed9a09bba45d2663ccac99e662201

aaronjensen commented 4 years ago

I'd imagine the images aren't very big, so you could put them in the repo if you'd like. Storing them elsewhere would save a bit of download for folks, but that shouldn't matter if you publish to melpa because i think they'd be stripped.

As an aside, here's a recipe for use-package + straight.el (once lfs is removed):

(use-package org-pandoc-import
  :straight (:host github
                   :repo "tecosaur/org-pandoc-import"
                   :files ("filters" "*.el")))

The filters directory won't get installed by default w/o specifying :files when using straight.

tecosaur commented 4 years ago

Cool, thanks. I'll update things in a bit. I just don't like how it feels to check binary files into git :sweat_smile:

tecosaur commented 4 years ago

I guess I probably could though, since they won't exactly be changing much.

tecosaur commented 4 years ago

@aaronjensen I think that should be fixed, please let me know :)

aaronjensen commented 4 years ago

That works, thanks!