UI: manual destination - Githubissues

tehp / OpenPoGoBot

A PokemonGo Python bot - NO LONGER MAINTAINED

MIT License

123 stars 53 forks source link

UI: manual destination #338

Closed niicojs closed 8 years ago

niicojs commented 8 years ago

Short Description:

Allow the UI to set a manual destination which will override current navigator until arrived. Need some tests.

Changes:

ability to break current navigation (code to be reviewed)
new internal navigator
some events to handle communication between parts

@OpenPoGo/maintainers

codecov-io commented 8 years ago

Current coverage is 52.89% (diff: 13.04%)

Merging #338 into master will decrease coverage by 0.09%

@@             master       #338   diff @@
==========================================
  Files            32         33     +1   
  Lines          1421       1450    +29   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            753        767    +14   
- Misses          668        683    +15   
  Partials          0          0

Powered by Codecov. Last update 34dcfc7...77982e6

wchill commented 8 years ago

👍

niicojs commented 8 years ago

I've tested it with both fort (will find fort at destination) and camper (will camp at destination). If someone could test it with a waypoint navigator, it should continue with with current waypoint after the manual detour. Maybe @andythorne, I think you use waypoint?

MaxLeiter commented 8 years ago

Waypoint worked over here

:+1: