Open mjhawkins opened 1 year ago
Warning in GS for absence of key - but no constraints on contents.
Move current rules to MC and make warnings not errors.
Right now, schematron only complains when the naming element occurs
msItem
(for author), origin
(settlement) or msDesc
(all other naming elements).ancestor::fileDesc//idno[@type='catalogue'] = 'Western'
. Do we want to keep one or both of these constraints?
That is, do we want the general schema only to complain
@key
is missing from a naming element in msItem
?or
msItem
and the file also has fileDesc//idno[@type='catalogue'] = 'Western'
or
All these items have the similar triggers applied to them on sch:rule's context attribute and similar constraints on the value of their key attribute. The only difference is the name of the element in question in the rule (i.e. author, persName, etc). It's probably best to debate them all at once since I believe they all belong in MC.
There are two separate issues with the changes to this element:
ancestor::fileDesc//idno[@type='catalogue'] = 'Western'
- must have key atributeThe regex on the assertion (person\d+ or place\d+) is too lax. It would match:
^person_\d+$
would likely work better.