search

tejuamirthi / CustomDropDown

Drop Down view for iOS using UIKit
Apache License 2.0
4 stars 6 forks source link

[BUG] DropDown toggle #17

Closed tejuamirthi closed 4 years ago

tejuamirthi commented 4 years ago

Describe the bug Right now, when we click on any part of the screen and if the dropdown is expanded already, it doesn't close.

To Reproduce Add a dropdown and try expanding and closing by tapping on different areas on screen

Expected behavior DropDown should collapse as soon as the user hits anywhere on the screen(If user hits on the dropdown view itself, it is handled)

Smartphone (please complete the following information):

FranklinSamboni commented 4 years ago

Hello there, I am working in this. Can you assign me this task ?

tejuamirthi commented 4 years ago

Thank you for the interest @FranklinSamboni Assigned

Contact me if you need anything else. Let me know the progress as well if you could, whenever necessary. Thanks!

FranklinSamboni commented 4 years ago

Done :D, if you have some feedback let me know. I also see a refactor code task running so I tried to change few things as possible to don't generate conflicts.

devanshimodha commented 4 years ago

Is this solved or not as the tag is available?

tejuamirthi commented 4 years ago

Hey @devanshimodha There’s a recent update in the ongoing pr, so have to review that before I can conclude the functionality. Please take a look at other issues and I’ll be a few new issues soon as well! Thank you for the interest

tejuamirthi commented 4 years ago

Mean time you can try #16 @devanshimodha It’s a simple but necessary one! Let me know if you need anything