tejuamirthi / CustomDropDown

Drop Down view for iOS using UIKit
Apache License 2.0
4 stars 6 forks source link

Cao issue 22 #37

Closed caocmai closed 3 years ago

caocmai commented 3 years ago

Description

I added the ability to change the background color of the dropdown list. I also added so whenever the dropdown list has an image then show that image along with the text in the selection view.

Fixes # 22

Type of change

Strictly added only UI changes.

How Has This Been Tested?

It has been tested on the iPhone 8 and iTouch 7 by the simulator was well as on my device.

Checklist:

Reviewers:

Please tag relevant people requesting a review

caocmai commented 3 years ago

Hi, thanks for the thorough feedback, I think I fixed everything. Also I decided to move the selected and background color of the dropdown in the config area instead of the view.

As regard to the colors, you can change it to whatever you think it's best I was just trying to show that it works, it's not important to me.

Uploaded new changes and requested new review. Thanks

tejuamirthi commented 3 years ago

Sorry for getting back late @caocmai