tektoncd / results

Long term storage of execution results.

Apache License 2.0

77 stars 73 forks source link

Add Release Cheatsheet for Results #441

Closed khrm closed 1 year ago

khrm commented 1 year ago

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Tested your changes locally (if this is a code change)
[ ] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

khrm commented 1 year ago

@enarha

khrm commented 1 year ago

Fixes #388

enarha commented 1 year ago

Generally the documentation is good. Following it, I was able to do the v0.7.0 release. There was an issue with storing the release.yaml and version folders in the correct paths, so I had to fix those manually. I'll look into this later to determine if it's something we need to fix in the script or in the documentation.

khrm commented 1 year ago

Does this release cheatsheet work fine? @enarha

enarha commented 1 year ago

The Cheatsheet is good and we can merge that PR. There is an issue which is a bug in some of the release scripts used. I've created https://github.com/tektoncd/results/issues/595 to handle it. [EDIT] I see I also mentioned that after the previous release, but unfortunately I did not follow up with a fix. Now that we have the issue, I hope it brings more attention to it.

enarha commented 1 year ago

/lgtm

khrm commented 1 year ago

@avinal Let's approve this. It might fix the go coverage test that's failing if this gets merged.

avinal commented 1 year ago

Yeah last release was successful, for now its good. We can iterate on this.

/approve /lgtm

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [avinal] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment