tektoncd / results

Long term storage of execution results.
Apache License 2.0
77 stars 73 forks source link

Bump go version to 1.19 #448

Closed avinal closed 1 year ago

avinal commented 1 year ago

Changes

/kind bug

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Release Notes

Minimum go version requirement updated to go1.19
tekton-robot commented 1 year ago

Hi @avinal. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
avinal commented 1 year ago

Should I update other dependencies as well?

alan-ghelardi commented 1 year ago

/approve

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alan-ghelardi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/results/blob/main/OWNERS)~~ [alan-ghelardi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
enarha commented 1 year ago

/ok-to-test

adambkaplan commented 1 year ago

Have you run go mod tidy and go mod vendor? I am somewhat surprised that changing the go.mod compatibility hasn't introduced any changes to go.mod and go.sum.

adambkaplan commented 1 year ago

(also interesting that we aren't checking that go.mod and go.sum are up to date/accurate).

avinal commented 1 year ago

Yes, I ran both the commands. I can bump the dependencies manually, though. If we want that.

enarha commented 1 year ago

/lgtm