Closed avinal closed 1 year ago
Hi @avinal. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Should I update other dependencies as well?
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alan-ghelardi
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/ok-to-test
Have you run go mod tidy
and go mod vendor
? I am somewhat surprised that changing the go.mod
compatibility hasn't introduced any changes to go.mod
and go.sum
.
(also interesting that we aren't checking that go.mod
and go.sum
are up to date/accurate).
Yes, I ran both the commands. I can bump the dependencies manually, though. If we want that.
/lgtm
Changes
/kind bug
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes