telegramdesktop / tdesktop

Telegram Desktop messaging app
https://desktop.telegram.org/
Other
26.43k stars 5.25k forks source link

Display the text of the quoted message, even after deleting the quoted message #28388

Open Dimoka113 opened 2 months ago

Dimoka113 commented 2 months ago

Steps to reproduce

  1. Quote any message
  2. Delete quoted message

Expected behaviour

The text of the quote should remain

Actual behaviour

Instead of a quote, only “deleted message” remains.

In addition, I can say that if you completely close the telegram using “ctrl + q”, then after opening the chat with this message, the quote will appear

Operating system

Windows 10

Version of Telegram Desktop

5.5.3

Installation source

Static binary from official website

Crash ID

No response

Logs

No response

LWChris commented 2 months ago

I would argue the bug is that the message re-appears after closing. Deleting a message should delete it. In my opinion, quoting a message shouldn't fixate it, as that would compromise the user's ability to delete a message at their own terms.

Dimoka113 commented 2 months ago

Well, I’m not entirely sure that the telegram mechanics can and/or should be discussed here (specifically its api, because the “quote_text” value is in the messageReplyHeader I just pointed out the differences between Telegram Desktop and other clients (example Telegram on Android)

Quote before deleting message: image

Quote after deleting a message: image

LWChris commented 2 months ago

Your screenshots are confusing to me. The deleted message appears to have been "Original message" but the quote only says "message" in both screenshots as if it was referencing a different message.

In Android, if I write 3 messages, 2 and 3 in reply to the previous one, I get this behavior:

Original:

1

1

2

2

3

If deleting message 1:

2

2

3

If deleting message 2:

1

3

If deleting message 3:

1

1

2

And that is what I described - when you delete a quoted message, the quoted message and the quote from the reply disappear. So I don't think your "Expected behaviour: The text of the quote should remain" is correct.