search

telerik / kendo-react

Issue tracker - KendoReact http://www.telerik.com/kendo-react-ui/
https://kendo-react-teal.vercel.app
Other
212 stars 39 forks source link

Vite ecommerce sample app #2687

Closed svdimitr closed 1 week ago

svdimitr commented 1 week ago

Related to https://github.com/telerik/kendo-react-private/issues/4360

The PR is opened so that we can deploy what we have so far. Polishing of the UI will be added in the next two days. The following discrepancies with the design can be expected:

  1. Not all buttons in the home page will lead to a specific product
  2. The "Vilora Jewelry picture" is not stretched to the full width
bptodorova commented 1 week ago

Make sure the following commands pass.

cd examples/ecommerce-jewellery-store
npm ci
npm run build
svdimitr commented 1 week ago

Make sure the following commands pass.

cd examples/ecommerce-jewellery-store
npm ci
npm run build
  • Currently npm ci says that there is divergency in package.json and package-lock.json
  • If I run npm i instead of npm ci and after that npm run build it fails with error TS17004: Cannot use JSX unless the '--jsx' flag is provided.

The npm ci command is fixed along with the --jsx flag. There are some build errors that were caused here https://github.com/telerik/kendo-react/pull/2687/commits/2ab47f883a84f9b9a002cefcb97a3297c09c40ba and we are fixing