search

telerik / kendo-themes

Monorepo for SASS-based Kendo UI themes
149 stars 71 forks source link

fix(grid): fix broken sticky row styles #5210

Closed epetrow closed 3 weeks ago

epetrow commented 3 weeks ago

Fixes a regression introduced with https://github.com/telerik/kendo-themes/pull/5133

inikolova commented 3 weeks ago

I think we should remove this row as well, as it is Angular specific -> https://github.com/telerik/kendo-themes/blob/fix-grid-sticky-rows-selection/packages/bootstrap/scss/grid/_theme.scss#L224

Also, I think it will be beneficial to add a visual test for covering sticky rows scenario

Juveniel commented 3 weeks ago

I don't think it is a good idea to return the kendo-grid selectors. Let's discuss this further and search for an alternative.

epetrow commented 3 weeks ago

I don't think it is a good idea to return the kendo-grid selectors. Let's discuss this further and search for an alternative.

I've refactored the commit, removed the kendo-grid selectors and tested the behaviour in an angular and react demo, but I'll need someone from the respective teams to verify.

epetrow commented 3 weeks ago

I think we should remove this row as well, as it is Angular specific -> https://github.com/telerik/kendo-themes/blob/fix-grid-sticky-rows-selection/packages/bootstrap/scss/grid/_theme.scss#L224

Also, I think it will be beneficial to add a visual test for covering sticky rows scenario

If we decide to do so due to the current differences in the rendering between the suites we will need to add two tests - one for React locked rows and one for Angular sticky rows

silviyaboteva commented 3 weeks ago

I think we should remove this row as well, as it is Angular specific -> https://github.com/telerik/kendo-themes/blob/fix-grid-sticky-rows-selection/packages/bootstrap/scss/grid/_theme.scss#L224 Also, I think it will be beneficial to add a visual test for covering sticky rows scenario

If we decide to do so due to the current differences in the rendering between the suites we will need to add two tests - one for React locked rows and one for Angular sticky rows

Guys, firstly, lets revamp and unify the rendering https://github.com/telerik/kendo-themes-private/issues/283 and after that we can have a single source of truth test.