teller-protocol / teller-protocol-v2-audit-2024

teller-protocol-v2-audit-2024
MIT License
0 stars 0 forks source link

Anyone can reset the prepared shares countdown for any other user #60

Open ethereumdegen opened 3 days ago

ethereumdegen commented 3 days ago

because it is possible to deposit on behalf of other users, anybody can reset each other's coundtowns by depositing small amounts on their behalf, DoSing withdrawals. Most of the protocols that include withdrawal queues force users to make two transactions: the withdrawal request and the actual withdrawal, which would make it optimal in this situation as you want to allow deposits on behalf of other users

ethereumdegen commented 3 days ago

could just ONLY reset countdown if msgsender == lender ?

no -- this wont work

ethereumdegen commented 3 days ago

see branch fix/issue-60 #63