search

tematres / TemaTres-Vocabulary-Server

Web application for management formal representations of knowledge, like controlled vocabularies, taxonomies, thesauri and glossaries
https://vocabularyserver.com
122 stars 53 forks source link

Language code format #28

Closed horus68 closed 2 years ago

horus68 commented 6 years ago

In /common/lang/en-utf-8.inc.php https://github.com/tematres/TemaTres-Vocabulary-Server/blob/master/common/lang/en-utf-8.inc.php

What is the usage for this string? define("LANG","en");

Does it need to be the same as used in $CFG["ISO639-1"]=array( and $idiomas_disponibles = array( https://github.com/tematres/TemaTres-Vocabulary-Server/blob/master/common/include/config.tematres.php#L71

Can we use a 4 letters format in language code or does it accept just the 2 letters format? I don't know if the language code acts as a key for the interface language file or any editor language file.

Some languages need to use the 4 letter code (xx-XX) as Portuguese and Chinese (or english US and GB) and any other regional variant in the future)

Note that Crwodin saves files automatically using the 4 letter code standard so it would be better to normalize this to xx-XX format.

If you want, I can make the change to the language files!

tematres commented 6 years ago

The LANG definition are only auto-description value, this label havent functional impact. We use the name of the file to select wich language file include. May be we can delete this label now. OK?

horus68 commented 6 years ago

Ok for me. On the name of the file can it be changed to use the 4 letters code for all language or just for the new ones in the future?

tematres commented 6 years ago

OK. I need to make some changes in the code to mantain legacy compatibility with tematres previous instances.

tematres commented 6 years ago

Yes we can! I working in this direction :)