search

tensorflow / mlir

"Multi-Level Intermediate Representation" Compiler Infrastructure
1.74k stars 260 forks source link

[ROCm] Add ROCDL Dialect. #63

Closed whchung closed 5 years ago

whchung commented 5 years ago

Add supporting logic to lower MLIR module into ROCm-Device-Libs (ROCDL) IR.

Follow-up to #57.

River707 commented 5 years ago

Make sure to squash all of your changes into one commit.

whchung commented 5 years ago

@River707 Thanks for your quick review! Pretty much all the issues you pointed out are in NVVM dialect as well. Should I file another PR to change it?

River707 commented 5 years ago

Is your question if you should file a PR to cleanup the NVVM dialect? If so that would be awesome, it needs to be cleaned up as well.

joker-eph commented 5 years ago

Hey @whchung, any update?

joker-eph commented 5 years ago

Closing for now since there hasn't been any activity for a month. Feel free to re-open as needed!

whchung commented 5 years ago

@joker-eph sorry I was focusing on internal tools based on mlir-rocm-runner lately. I'll revisit the PRs I submitted next week.

joker-eph commented 5 years ago

Good to hear! No hurry, I just closed to keep our open pull-requests count lower as we try to keep an eye on all the active ones.