search

teo-jun-xiong / pe

0 stars 0 forks source link

Result display for error does not match error #1

Open teo-jun-xiong opened 4 years ago

teo-jun-xiong commented 4 years ago

Using the command, the result display does not state what the error is, because the format of the dates are indeed in DDMMYYY. No indication of Feburary not having 29/30 days in that year, or the date given does not exist.

Here are some more commands and not being able to understand what is wrong with it.

image.png

image.png

It is not clear what is wrong with the command, invalid date, year, or range?

nus-pe-bot commented 4 years ago

Team's Response

It is hard to catch every single error related to dates as in our code, we are reliant on the LocalDate API provided by Java to parse the dates, and in their implementation, there was no way to discern if the error in the date is due to the leap years, invalid date, etc.

We understand that we should have been more clear with our error messages when it comes to the dates, and will take this issue into consideration in the future.

The bug type has been changed to FeatureFlaw as the exception is still caught as intended, it is only that the displayed error message is not specific enough.

Items for the Tester to Verify

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your reason]