search

terminal42 / contao-leads

Leads extension for Contao Open Source CMS; Store and manage form data with ease!
GNU Lesser General Public License v3.0
35 stars 24 forks source link

migrate from PHPExcel to PhpSpreadsheet #66

Closed MDevster closed 5 years ago

MDevster commented 5 years ago

fixes #58

zonky2 commented 5 years ago

added with https://github.com/terminal42/contao-leads/commit/432c96131b2848c9e46a4541c38ef501938513d7

aschempp commented 5 years ago

Looks like this was not fully merged, at least the composer.json is not update? And not sure about the other changes suggested here? @richardhj can you check this?

aschempp commented 5 years ago

Also see https://github.com/terminal42/contao-leads/issues/58

richardhj commented 5 years ago

PR is outdated and compatibility with php-spreadsheet already given.

aschempp commented 5 years ago

But not everything from this PR has been merged? E.g. the suggest in composer.json is still wrong?