search

terminal42 / contao-url-rewrite

Provides a back end module in Contao that allows you to specify url rewrites that are added to the Symfony Route collection
MIT License
15 stars 4 forks source link

Import feature #13

Closed dmolineus closed 5 years ago

dmolineus commented 5 years ago

For a project I need the possibility to import rewrite rules from a file (very likely csv). I'm thinking about implementing a custom config provider for it or contribute an import feature. Would you accept the last as an PR?

Toflar commented 5 years ago

Hmmm...why do you need an import? Do they have to be updated by the user? I mean, do they even need to be shown in the back end? Which Contao version are you going to work with?

dmolineus commented 5 years ago

Hmmm...why do you need an import? Do they have to be updated by the user?

What customer wants the ability to regularly update defined rewrite rules. The admin shouldn't have to be involved all the time

I mean, do they even need to be shown in the back end?

There are two use case scenarios:

Which Contao version are you going to work with?

Contao >= 4.7.

If you think an import feature would be useful I'm happy to provide a PR. If not, also fine. Totally understand if you plan to keep your extension in a manageable size.

Toflar commented 5 years ago

Yeah I just wonder if you'd be better off just writing your own router as in Contao 4.7 we now use the Symfony CMF ChainRouter. So it should be as easy as to tag a service that returns your custom route collection based on your file. It's probably easier than to write an import. Yet still, I'm open to import/export features, just not sure about the best format.

dmolineus commented 5 years ago

I'm closing this issue. Resolved with a custom script and won't have any budget working on a generic import right now.