termux / termux-x11

Termux X11 add-on application.

https://termux.dev

GNU General Public License v3.0

1.98k stars 304 forks source link

Frequent crashing in direct input mode #118

Closed personalizedrefrigerator closed 1 year ago

personalizedrefrigerator commented 2 years ago

Summary

Seemingly random crashes after doing multi-finger gestures in direct input mode
Crashing does not occur directly after sending input --- it seems more random
I'm unable to reproduce the crash when using "emulate touchpad" mode/when using a physical mouse.

Additional details

Android 12 (with max_phantom_processes set to a very large number)
Running XFCE4 session
I don't know how to get a crash log!

RalfWerner commented 2 years ago

This is a known bug and already included in the first version of @twaik on all devices. Only the other two modes are stable.

twaik commented 1 year ago

Direct touch mode removed in https://github.com/termux/termux-x11/commit/540dcbebc8a46d8077396154c87ea35dd6427bde

RalfWerner commented 1 year ago

Why removed? This is the only way to implement X applications with multi-touch functionality and in VNC is it not possible! On most of my devices, this is possible without crash. Is there an alternative for multi-touch? android:defaultValue="1" in app/src/main/res/xml/preferences.xml is Ok and enought

twaik commented 1 year ago

I can not fix a bug which I can not reproduce. If you can get detailed log of what exactly crashes I will restore this. Do you know work with debugger?

RalfWerner commented 1 year ago

I can try it, but you would have to reset the commit (reopen this issue), before I clone termux-x11. I am currently working with old X11 versions. Mainly with the ekeys brunch and I've at least one real device where I can reproduce it. I would use Android-Studio*) You may still remember our SSM campaign. Multi-touch ist not the same but similar. Long time ago (2019) you've created a check-tool - see the last 15 seconds of this Video

*) but not on an emulated device! The fingers - up to 10 without feet:) are the main input device on mobile phones! Why should it be limited to just one finger? My test X application works very well with 2-4 fingers. But I don't get much more on it when I hold the device with the other hand.

twaik commented 1 year ago

SSM

It should be fixed by https://github.com/termux/termux-x11/commit/a868f37c8ae4aeb54f2c5e53b0ee02db0dfba0b9 . For some reason sockets came in some broken state and wayland could not drop them. I really tried to fix it but now sometimes it breaks launching sequence. I am already working on something that will fix it.

Multi-touch ist not the same but similar.

It feels like Android sometime sends touch events in wrong order. I will test it a bit later.

Mainly with the ekeys brunch

I will work on it only after adding clipboard and sending unicode symbols, it is possibly only with X11 client. It is not real with current project state.

RalfWerner commented 1 year ago

Your last version cannot be built! But that from February 8th. In between, the data is reduced from 3.2MB to 1.7MB. I get the message:Build file 'D:\Android\termux-x11\app\build.gradle' line: 72 What is ant.patch(...?

twaik commented 1 year ago

It is likely because of submodules. I'l fix it later...