terra-sync / cnc

Seamless Database Replication tool
GNU General Public License v3.0
4 stars 2 forks source link

rust: read email body from file #54

Closed zycon91 closed 3 months ago

zycon91 commented 3 months ago

This commit will make it possible to read the mail body from a file. The EmailInfo struct will have a filepath parameter instead of body.

Changelog:

charmitro commented 3 months ago

Didn't find something that worries me by having a quick look.

I'll take a look tomorrow but for starters let's format C code with clang-format, and Rust code with cargo fmt.

@zycon91 Did you manage to run this in MacOS? If not, can you specify the issues so we can work on them?

zycon91 commented 3 months ago

Didn't find something that worries me by having a quick look.

I'll take a look tomorrow but for starters let's format C code with clang-format, and Rust code with cargo fmt.

@zycon91 Did you manage to run this in MacOS? If not, can you specify the issues so we can work on them?

Unfortunately I wasn't able to compile it on MacOS. The error I was getting is the following: src/postgres.c:3:10: fatal error: 'error.h' file not found

It is pointing to src/test-postgress.o in the #include <error.h> line specifically.

charmitro commented 3 months ago

Before proceeding with the merge, @panosfol and @zycon91, please ensure you coordinate to implement the email feature in PostgreSQL db-operation."

panosfol commented 3 months ago

Before proceeding with the merge, @panosfol and @zycon91, please ensure you coordinate to implement the email feature in PostgreSQL db-operation."

When this pr is ready to be merged, Ill push here my changes to implement the feature for Postgres

charmitro commented 3 months ago

Oops, seems the CI detected some unused imports or unresolved. @zycon91

zycon91 commented 3 months ago

Oops, seems the CI detected some unused imports or unresolved. @zycon91

yea. just saw it! On it