fix: Allow multiple step adjustments for step scaling and v5.0 provider upgrade

terraform-aws-modules / terraform-aws-autoscaling

Terraform module to create AWS Auto Scaling resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws

Apache License 2.0

288 stars 552 forks source link

fix: Allow multiple step adjustments for step scaling and v5.0 provider upgrade #240

Closed magreenbaum closed 9 months ago

magreenbaum commented 11 months ago

Description

Step scaling allows for multiple step adjustments to be configured. Also bumped module to terraform v1.0 and aws provider v5.0.

Motivation and Context

Resolves: https://github.com/terraform-aws-modules/terraform-aws-autoscaling/issues/236

Breaking Changes

Yes, anyone previously specifying step_adjustments will need to change step_adjustment config from a map to a list of maps as shown in the updated example.

Also aws provider v5.0 upgrade.

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

bryantbiggs commented 11 months ago

FYI - if we take a breaking change, we should make all breaking changes at once to reduce the amount of disruption https://github.com/terraform-aws-modules/terraform-aws-autoscaling/pull/204

github-actions[bot] commented 10 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

magreenbaum commented 10 months ago

Unstale

github-actions[bot] commented 9 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

magreenbaum commented 9 months ago

unstale

bryantbiggs commented 9 months ago

resolved in #204

antonbabenko commented 9 months ago

This issue has been resolved in version 7.0.0 :tada:

github-actions[bot] commented 8 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.