feat: Add support multiple service connect

terraform-aws-modules / terraform-aws-ecs

Terraform module to create AWS ECS resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/ecs/aws

Apache License 2.0

573 stars 542 forks source link

feat: Add support multiple service connect #208

Closed ladung closed 5 months ago

ladung commented 5 months ago

During deploy my services on ECS, I have used this module as base module to create ecs cluster, ecs service and task definition. However, some services need to config multiple service connect, I have tried multiple time with latest version of the module but it's still not working. So I have written the module service in sub module and my services were working. Hope this PR will be merged asap to other person can use it like me.

bryantbiggs commented 5 months ago

this has already been merged into the v6 branch with #123 - it will be part of the v6.0 when released

github-actions[bot] commented 4 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.