Module should chain-output "security_group_id" from child module "service"

terraform-aws-modules / terraform-aws-ecs

Terraform module to create AWS ECS resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/ecs/aws

Apache License 2.0

573 stars 542 forks source link

Module should chain-output "security_group_id" from child module "service" #220

Closed partlythomas closed 2 months ago

partlythomas commented 3 months ago

Describe the solution you'd like.

The child module "service" is outputting the security_group_id tied to the ECS service. However, the "root" module does not further chain this output, making it inaccessible for module calls outside of this module. This would be particularly useful in order to limit the network access scope between the load balancer and the ECS services, rather than just using the CIDR of the whole VPC.

bryantbiggs commented 2 months ago

it does, you just have to extract it from https://github.com/terraform-aws-modules/terraform-aws-ecs/blob/3b70e1e46e1b96a2da7fbfe6e2c11d44009607f1/outputs.tf#L59-L62

github-actions[bot] commented 1 month ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.