fix: Propagate support for EBS volumes to the root module

terraform-aws-modules / terraform-aws-ecs

Terraform module to create AWS ECS resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/ecs/aws

Apache License 2.0

573 stars 542 forks source link

fix: Propagate support for EBS volumes to the root module #223

Closed montaguethomas closed 2 months ago

montaguethomas commented 2 months ago

Description

The PR https://github.com/terraform-aws-modules/terraform-aws-ecs/pull/205 failed to update the main module triggered when using the Terraform Registry as the module source.

Motivation and Context

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[ ] I have executed pre-commit run -a on my pull request

bryantbiggs commented 2 months ago

this is already included in #217 and will go out on the next major version release since its part of a breaking change

montaguethomas commented 2 months ago

@bryantbiggs I'm tracking the wip/v6 branch has the initial implementation. This PR is resolving missing parts and logic of that implementation.

bryantbiggs commented 2 months ago

ah my apologies!

github-actions[bot] commented 1 month ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.