fix: Correct logic for local `needs_infrastructure_iam_role` check - Githubissues

terraform-aws-modules / terraform-aws-ecs

Terraform module to create AWS ECS resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/ecs/aws

Apache License 2.0

573 stars 542 forks source link

fix: Correct logic for local `needs_infrastructure_iam_role` check #224

Closed montaguethomas closed 2 months ago

montaguethomas commented 2 months ago

Description

@bryantbiggs sorry for the iteration, but #223 merged in before I could push another fix to the infra role logic.

Motivation and Context

volume_configuration variable is defaulted to {}, which the null check will never work.

Breaking Changes

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[ ] I have executed pre-commit run -a on my pull request

github-actions[bot] commented 1 month ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.