Add support for managed_draining for capacity provider

vjancich commented 1 month ago

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

Yes ✅: please list the AWS provider version which introduced this functionality Introduced with provider version 5.34.0: https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.34.0

Is your request related to a problem? Please describe.

We want to enable AWS managed ECS draining for our ECS clusters. For new capacity providers, this is enabled by default but for existing it needs to be explicitely enabled.

Describe the solution you'd like.

Add managed_draining property into aws_ecs_capacity_provider resource.

Additional context

AWS announcement: https://aws.amazon.com/about-aws/whats-new/2024/01/amazon-ecs-managed-instance-draining/ Terraform docs: https://registry.terraform.io/providers/hashicorp/aws/5.70.0/docs/resources/ecs_capacity_provider#managed_draining

vinfang commented 1 month ago

So I had thought that someone had made an issue already and implemented this via https://github.com/terraform-aws-modules/terraform-aws-ecs/issues/174 problem is I don't know the process here and am wondering when this update is getting pushed out for this module. I've been waiting for this update as well.

github-actions[bot] commented 5 days ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

vjancich commented 4 days ago

Still needed, don't close.

terraform-aws-modules / terraform-aws-ecs