terraform-aws-modules / terraform-aws-eks

Terraform module to create Amazon Elastic Kubernetes (EKS) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/eks/aws
Apache License 2.0
4.48k stars 4.09k forks source link

fix: Add `primary_ipv6` parameter to self-managed-node-group #3169

Closed jmtsi closed 1 month ago

jmtsi commented 1 month ago

Description

The launch template config in self-managed-node-group didn't include the parameter to set primary_ipv6, so I add it here. This has already been implemented for eks-managed-node-group in this PR

Motivation and Context

This parameter is needed to enable Assign primary IPv6 IP for self-managed-node-group nodes. This is required to make it possible to use instance-type targets when using IPv6 and AWS Load Balancer Controller

Breaking Changes

Simple addition, no breaking changes

How Has This Been Tested?

antonbabenko commented 1 month ago

This PR is included in version 20.24.3 :tada:

jmtsi commented 1 month ago

Wow, thanks for the quick reaction to my PR!

github-actions[bot] commented 3 weeks ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.