terraform-aws-modules / terraform-aws-eks

Terraform module to create Amazon Elastic Kubernetes (EKS) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/eks/aws
Apache License 2.0
4.48k stars 4.09k forks source link

bootstrap_extra_args (bottlerocket) ignored if use_custom_launch_template=false #3175

Closed kr4sv closed 1 month ago

kr4sv commented 1 month ago

When use_custom_launch_template is set to false on a managed node group, bootstrap_extra_args are no longer appended to the bottlerocket user_data.

bootstrap_extra_args not appended

managed-ondemand-nvidia = {
  use_custom_launch_template = false
  instance_types             = var.gpu_types
  ami_type                   = "BOTTLEROCKET_x86_64_NVIDIA"
  disk_size                  = var.mng_disk_size
  subnet_ids                 = [module.vpc.private_subnets[0]]
  bootstrap_extra_args       = <<-EOT
    [kubelet-device-plugin.nvidia]
    device-list-strategy = "envvar"
  EOT
  }

bootstrap_extra_args correctly appended

managed-ondemand-nvidia = {
  instance_types             = var.gpu_types
  ami_type                   = "BOTTLEROCKET_x86_64_NVIDIA"
  subnet_ids                 = [module.vpc.private_subnets[0]]
  bootstrap_extra_args       = <<-EOT
    [kubelet-device-plugin.nvidia]
    device-list-strategy = "envvar"
  EOT
  }

Not sure if this is by design (not documented though) or unintentional.

bryantbiggs commented 1 month ago

additional user data is only supported by EKS managed node groups via a custom launch template

github-actions[bot] commented 2 weeks ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.