terraform-docs / gh-actions

A Github action for generating Terraform module documentation using terraform-docs and gomplate
Apache License 2.0
144 stars 61 forks source link

The `set-output` command is deprecated and will be disabled soon #97

Closed gtazzoli-uala closed 5 months ago

gtazzoli-uala commented 1 year ago

Describe the bug

When running from @v1.0.0 or main I get:

Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see:

How can we reproduce it?

  - name: Update README.md docs
    id: update-readme
    uses: terraform-docs/gh-actions@main #or v1.0.0 
    with:
      working-dir: .
      output-file: README.md
      output-method: inject
      git-push: "true"
      config-file: './.config/.terraform-docs.yml'
lbeltramino commented 1 year ago

I'm having the same issue. Hope this is fixed soon.

cordobacancun commented 1 year ago

Same Here! Hope this is fixed soon.

charly942 commented 1 year ago

I still have the same problem too, hope this is fixed soon.

jhegert-infraDevOps commented 1 year ago

Experiencing the same issue. Hope they fix this soon!

GonzaloRodriguezCabrera commented 1 year ago

I'm having the same issue. Hope this is fixed soon.

heuerluis commented 1 year ago

Hi all, I´ve got the same problem. Thanks so much for showing this issue. Fixing it will be great for me too.

jvidelaolmos commented 1 year ago

I'm facing the same issue here.

gomeznf commented 1 year ago

Hi, I'm having the same issue here. Hope this is fixed soon. Thanks in advance.

db4rr3t0 commented 1 year ago

I'm having the same issue here.

katanita commented 1 year ago

I'm facing the same issue here. Hope it gets fixed soon.

nicolascavedale commented 1 year ago

I'm having the same issue! Please fix this.

jonathanio commented 1 year ago

There is a commit (https://github.com/terraform-docs/gh-actions/commit/18dc76d9b2e3c746cf6f8e073c7fa7df16dcf620) with the fix in main, but there is no release with this change. Getting a v1.0.1 release out would be great!

I think in the meantime you can use the following override:

    - name: Render terraform docs inside the README.md and push changes back to PR branch
      uses: terraform-docs/gh-actions@18dc76d9b2e3c746cf6f8e073c7fa7df16dcf620
      with:
        ...
ipc-zpg commented 1 year ago

even with this:

       - name: Render terraform docs and push changes back to PR
         uses: terraform-docs/gh-actions@18dc76d9b2e3c746cf6f8e073c7fa7df16dcf620
         with:
           working-dir: ./liftshift_terraform/
           output-file: README.md
           output-method: inject
           git-push: "true"

I am getting:

<!-- END_TF_DOCS --> ./liftshift_terraform/
liftshift_terraform/README.md updated successfully
::debug No change in ./liftshift_terraform// detected
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
::debug No files changed, skipping commit
gtazzoli-uala commented 1 year ago

Hello,

Just an update. From @main still the same. What I did was to create my own Docker image using the Dockerfile that was updated on recent commits and pulled that image to my own public repository. Then I forked this repo and updated the action.yml with the new image and the warnings have gone. They need to build and pull a new image and update the action.yml on this repo to make it work. Until that we have to wait or make our own.

Cheers! Gus.

chrisdleech-pol commented 1 year ago

Hello,

Just an update. From @main still the same. What I did was to create my own Docker image using the Dockerfile that was updated on recent commits and pulled that image to my own public repository. Then I forked this repo and updated the action.yml with the new image and the warnings have gone. They need to build and pull a new image and update the action.yml on this repo to make it work. Until that we have to wait or make our own.

Cheers! Gus.

Thanks for the tip, it worked for me. I had to add the following to the Dockerfile to get it to build though: https://www.alpinelinux.org/posts/Alpine-edge-signing-keys-rotated.html

marcofranssen commented 1 year ago

Could we get a release containing the fix mentioned above?

git tag -sam "This release adds …" v1.0.1
git push origin v1.0.1
MitchellPaff commented 1 year ago

A release containing this fix would be appreciated soon. We are approaching May31st with an average speed of 24hrs per day.

marcofranssen commented 1 year ago

@khos2ow are you able to help. I have seen you have been one of the most active committers here, so hoping you are a maintainer who can cut a release.

arogic commented 1 year ago

Can we have an ETA? Thanks in advance.

marcofranssen commented 1 year ago

@metmajer are you able to help cutting a release?

gonzaatcroud commented 1 year ago

@metmajer @khos2ow appreciate the help if possible, I'd hate to have to remove the action from our workflows given it's been working so well.

bahag-hammera commented 1 year ago

Are there any news on this topic?

sangameshajm commented 1 year ago

GitHub is monitoring telemetry for the usage of these save-state and set-output and plan to fully disable them on 31st May 2023. Starting 1st June 2023 workflows using save-state or set-output commands via stdout will fail with an error.

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Please try to address this asap

mcantinqc commented 1 year ago

I check this issue and the fix is already in the main branch, https://github.com/terraform-docs/gh-actions/pull/94, but there are no new version since the fix.

The codeowner (@khos2ow ) need to release a new version and update the docker version on that line https://github.com/terraform-docs/gh-actions/blob/main/action.yml#L88.

MarkRoss-Eviden commented 11 months ago

Any update on this, is this repo and action still being managed?

marcofranssen commented 11 months ago

@metmajer @khos2ow is this repo still maintained? Are you looking for maintainers? Would be great to get some updates on this action.

I'm also happy to contribute the fixes required, just want to confirm the fixes are going to be merged and released.

khos2ow commented 5 months ago

This is now released and available in v1.1.0. Sorry for the very long delay.

I'm going to close this and mark it as done.