search

terraform-google-modules / terraform-google-iam

Manages multiple IAM roles for resources on Google Cloud
https://registry.terraform.io/modules/terraform-google-modules/iam/google
Apache License 2.0
189 stars 170 forks source link

feat: Add support for conditional for custom role member #217

Closed ps-occrp closed 1 week ago

ps-occrp commented 4 months ago

Add support for conditional for custom role member

ps-occrp commented 4 months ago

@imrannayer or @apeabody can you please review this PR?

imrannayer commented 4 months ago

@ps-occrp thx for the PR. Is it possible if you can follow the same pattern we have for other modules? See project IAM example

ps-occrp commented 4 months ago

@imrannayer Can you check now?

imrannayer commented 4 months ago

@ps-occrp can u plz add a condition in example so we can make it part of integration test?

imrannayer commented 4 months ago

/gcbrun

ps-occrp commented 4 months ago

@imrannayer can this be merged?

imrannayer commented 4 months ago

@bharathkkb can u plz review? I dont have permission on this repo.

ps-occrp commented 2 months ago

@bharathkkb Can this be merged?

github-actions[bot] commented 2 weeks ago

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days