terraform-google-modules / terraform-google-kubernetes-engine

Configures opinionated GKE clusters
https://registry.terraform.io/modules/terraform-google-modules/kubernetes-engine/google
Apache License 2.0
1.15k stars 1.17k forks source link

chore: update example module sources and versions #2116

Closed wyardley closed 2 months ago

wyardley commented 2 months ago

Follow-up to https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/2115#issuecomment-2375056239

For example this:

module "permissions" {
  source = "../../modules/fleet-app-operator-permissions"
  # also no version specification here
}

gets rewritten like this when the docker test / lint make target is run.

--- a/examples/autopilot_private_firewalls/main.tf
+++ b/examples/autopilot_private_firewalls/main.tf
@@ -33,7 +33,7 @@ provider "kubernetes" {
 }

 module "gke" {
-  source                            = "../../modules/beta-autopilot-private-cluster/"
+  source                            = "wyardley/kubernetes-engine/google//modules/beta-autopilot-private-cluster"
   project_id                        = var.project_id
   name                              = "${local.cluster_type}-cluster"
   regional                          = true
apeabody commented 2 months ago

/gcbrun

apeabody commented 2 months ago

/gcbrun

apeabody commented 2 months ago

/gcbrun

wyardley commented 2 months ago

@apeabody ack, another flake maybe?

apeabody commented 2 months ago

@apeabody ack, another flake maybe?

Yup, slow API activation