terraform-ibm-modules / terraform-ibm-cos

Configures an IBM Cloud Object Storage instance and bucket
Apache License 2.0
11 stars 24 forks source link

Remove `ibm_iam_account_settings` from COS module #742

Closed ocofaigh closed 1 month ago

ocofaigh commented 1 month ago

The ibm_iam_account_settings data lookup requires admin account privileges, so we should avoid using when we can.

In the secure-cross-regional-bucket and secure-regional-bucket DAs its used to get account IDs however the account ID can be parsed (using our CRN parser module) from the COS instance ID which is passed in to these DAs as an input.

~As part of this effort I think it might help consuming modules if there was an account ID output for the modules, and applicable submodules~ done in https://github.com/terraform-ibm-modules/terraform-ibm-cos/pull/743

Soaib024 commented 1 month ago

PR merged - closing the issue