search

terraform-redhat / terraform-rhcs-rosa-hcp

Repository for rosa hcp modules
3 stars 15 forks source link

OCM-12048 | feat: include indicator for bypassing machine pool deletion errors #48

Closed gdbranco closed 2 weeks ago

gdbranco commented 1 month ago

OCM-12048

openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gdbranco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/terraform-redhat/terraform-rhcs-rosa-hcp/blob/main/OWNERS)~~ [gdbranco] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hunterkepley commented 2 weeks ago

/lgtm

hunterkepley commented 2 weeks ago

I don't think I can merge still, but LGTM