Converting a geo-object type's visibility from public to private does not make the hierarchies that contains it private as well

[SteeveEbener]

List the CGR information

• CGR version: 0.13.1
• CGR instance (e.g. a URL): staging

Describe the bug (clear and concise) Converting the visibility of a geo-object type's being the lowest child of any hierarchy from public to private does not make the hierarchies that contains this geo-object type private as well

To Reproduce As the Moh RA and using Tolkien data:

2. Go to the lists module
3. Convert the visibility of the community health workers list from public to private (can't change the visibility of a geo-object type without changing the one of the list first => See item No 66 in the user feedback google spreadsheet)
4. Go to the geo-object types and hierarchies module
5. Convert the visibility of the Community Health Worker (MOH) geo-object type from public to private
6. Look at the content of the "CHW-Health Post Hierarchy (MOH)" Hierarchy => CHW are still there (normal)
7. Log out as Moh RA and log in as Moha RA
8. Go to the geo-object types and hierarchies module
9. Look at the Hierarchies section => Error 1: the "CHW-Health Post Hierarchy (MOH)" Hierarchy
10. Open the "CHW-Health Post Hierarchy (MOH)" Hierarchy => Error 2 => The hierarchy is now incomplete as the CHW geo-object type has been made private (see screenshot below)

Expected behavior (clear and concise) "Privatizing" The geo-object type at the lowest level of any hierarchy privatize the hierarchies in question

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Browser: Google Chrome
• Version: Version 87.0.4280.88 (Official Build) (64-bit)

Additional context (if any)

• If you continue "privatizing" the geo-object types from the lowest level to the highest you are most likely going to end up with an empty hierarchy while it still appears in the list
• See the public-restricted-private relation included in this schema for reference: https://www.dropbox.com/s/ylx3q1h9dn2gswo/Public_restricted_private_051020.pdf?dl=0

[rrowlands]

Duplicate of #435

[SteeveEbener]

This is not a duplicate of #435. Can you please re-open this ticket? Thanks

[justinlewis]

Reopened because:

511 seeks to make all hierarchies that contain a Geo-Object Type private if that Type is first made private

While

435 is asking for a visibility setting for the whole hierarchy to be made public or private. #435 needs to be done in order to implement this ticket