search

terrestris / shogun-legacy

⛔️ DEPRECATED, please use https://github.com/terrestris/shogun-core
Other
16 stars 16 forks source link

Adapt column name for MS SQLServer compatibility #54

Open buehner opened 10 years ago

buehner commented 10 years ago

KEY seems to be a reserved word in SQLServer, so hibernate could not create the schema correctly.

Please review and merge!

chrismayer commented 10 years ago

Hi @buehner , since this only changes the DB itself and it does not affect any other components becuse of the mapping feel free to merge! Thank you!

marcjansen commented 10 years ago

What does this mean if someone updated an existing SHOGun to use this new mapping?

Will hbm2ddl=UPDATE work and rename the column? I am unsure about whether we want to merge this.

chrismayer commented 10 years ago

Oh yes, @marcjansen good point, haven't thought about this. I am also unsure if hbm2ddl=UPDATE will do the stuff for you. Maybe we need a kind of update strategy or a kind of mapping so both column names can work (did not investigate if there is something offering such a mapping)